appDisplay: Clicking outside folders does not consistently close them

This is because the container of the dialog changes sizes after a
refresh, for reasons that are not fully explained. A better condition
is to check explicitly that the click doesn't fall into the dialog.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7541
Co-authored-by: Florian Müllner <fmuellner@gnome.org>
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3713>

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index e5fcbb5bc62e4537e95b68b71995dacbc5b4f9a0..393e49e988a68f84310bd3f71bcde9468606ccde 100644 (file)
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2500,7 +2500,7 @@ export const AppFolderDialog = GObject.registerClass({
             const actor =
                 global.stage.get_actor_at_pos(Clutter.PickMode.ALL, x, y);
 
-            if (actor === this)
+            if (!this._viewBox.contains(actor))
                 this.popdown();
         });
         this.add_action(clickAction);